Fix partner view to display distribution scheduled date #4860
Conversation
spec/system/partner_system_spec.rb
Outdated
| @@ -317,6 +317,21 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| context "when viewing prior distributions" do | |||
There was a problem hiding this comment.
Since this test doesn't require any browser interactivity/javascript, it could probably be changed from a system spec to be a request spec. Because system specs are pretty slow.
There was a problem hiding this comment.
FWIW, I guarantee @dorner will strongly suggest the same thing.
There was a problem hiding this comment.
Indeed. 😁 Can it please be moved to a request spec?
There was a problem hiding this comment.
Good call! I was AFK for a bit due to the holidays, but I updated this PR to use a request spec instead of a system spec. I also fixed what appeared to be a typo in the request spec, but please let me know if I was incorrect in making that change.
|
LGTM from a functional POV |
spec/system/partner_system_spec.rb
Outdated
| @@ -317,6 +317,21 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| context "when viewing prior distributions" do | |||
There was a problem hiding this comment.
Indeed. 😁 Can it please be moved to a request spec?
Resolves #4856
Description
Previously, the partner view's "prior distributions" section included the date when distributions were entered into the system. Now, the "prior distributions" section will instead include the distribution scheduled date.
Type of change
How Has This Been Tested?
Screenshots
Before
After